check for "no change" #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levb
commented
Feb 2, 2020
levb
commented
Feb 2, 2020
| @@ -354,7 +354,6 @@ func TestAPI(t *testing.T) { | |||
| api.On("UnregisterCommand", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return((*model.AppError)(nil)) | |||
| api.On("GetChannel", mock.AnythingOfType("string")).Return(&testChannel, nil) | |||
| api.On("GetTeam", mock.AnythingOfType("string")).Return(&testTeam, nil) | |||
| api.On("GetUser", mock.AnythingOfType("string")).Return(&testTeam, nil) | |||
crspeller
approved these changes
Feb 3, 2020
crspeller
added a commit
that referenced
this pull request
Feb 3, 2020
* Adding API for adding/replacing links. * link -> autolink * Adding an autolink client * Renaming and content type. * Moving to using headers to transmit plugin id. * check for "no change" (#88) * check for "no change" * fixed an error treating empty UserID * minor Co-authored-by: Lev <[email protected]>
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.