-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly escape $-usage with span-tags #198
Properly escape $-usage with span-tags #198
Conversation
On May 19th GitHub Markdown started to support math-mode using `$`-signs which breaks the documentation; see usage [here](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions)
Hello @ichistmeinname, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 40.79% 40.79%
=======================================
Files 6 6
Lines 679 679
=======================================
Hits 277 277
Misses 382 382
Partials 20 20 Continue to review full report at Codecov.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
Summary
On May 19th GitHub Markdown started to support math-mode using
$
-signs which breaks the documentation; see usage here. Span-tags are the way to fix a direct usage of$
in text mode.