Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape $-usage with span-tags #198

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

ichistmeinname
Copy link
Contributor

Summary

On May 19th GitHub Markdown started to support math-mode using $-signs which breaks the documentation; see usage here. Span-tags are the way to fix a direct usage of $ in text mode.

On May 19th GitHub Markdown started to support math-mode using `$`-signs which breaks the documentation; see usage [here](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions)
@ichistmeinname ichistmeinname requested a review from levb as a code owner July 6, 2022 15:43
@mattermod
Copy link
Contributor

Hello @ichistmeinname,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@ichistmeinname
Copy link
Contributor Author

/check-cla

@codecov-commenter
Copy link

Codecov Report

Merging #198 (cd5637f) into master (3282131) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files           6        6           
  Lines         679      679           
=======================================
  Hits          277      277           
  Misses        382      382           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3282131...cd5637f. Read the comment docs.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 2, 2022
@hanzei
Copy link
Contributor

hanzei commented Nov 2, 2022

/check-cla

@hanzei hanzei requested a review from jespino November 22, 2022 12:55
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@mickmister mickmister merged commit 3a68c6d into mattermost-community:master Feb 21, 2023
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants