Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.0 #101

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Bump version to 1.2.0 #101

merged 2 commits into from
Apr 6, 2020

Conversation

jfrerich
Copy link
Contributor

@jfrerich jfrerich commented Mar 19, 2020

Summary

Bump version to v1.1.3

Proposal to bump Minor Version to prep for release with the following Release Notes:

Enhancements

Fixes

Ticket Link

https://mattermost.atlassian.net/browse/MM-23175

Outstanding PRs

@hanzei
Copy link
Contributor

hanzei commented Mar 19, 2020

Why is this a patch release if features are added?

@jfrerich
Copy link
Contributor Author

@hanzei you are correct. I'll keep the branch and increment the feature, not the patch

@codecov-io
Copy link

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   36.43%   36.43%           
=======================================
  Files           6        6           
  Lines         538      538           
=======================================
  Hits          196      196           
  Misses        320      320           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e53e3f...1f67a1b. Read the comment docs.

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 19, 2020
@jfrerich
Copy link
Contributor Author

jfrerich commented Mar 19, 2020

The following PRs are outstanding. They aren't labeled for this release but it would be great if we could get them in first.

#98
#93

@hanzei hanzei changed the title Bump version to 1.1.3 Bump version to 1.2.0 Mar 19, 2020
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

One nit: Item 1 and 2 from the "Fixes" list are "Enhancements" IMO

@jfrerich jfrerich self-assigned this Mar 24, 2020
@levb levb removed the 2: Dev Review Requires review by a core committer label Mar 25, 2020
@hanzei hanzei added this to the v1.2.0 milestone Mar 31, 2020
@hanzei hanzei requested a review from DHaussermann March 31, 2020 09:53
@hanzei
Copy link
Contributor

hanzei commented Mar 31, 2020

All PR for this release have been merged 🚀

@jfrerich
Copy link
Contributor Author

Thanks for the update on #98, @hanzei!

@aaronrothschild, @DHaussermann we can tag autolink with release version v1.2.0 once PM and QA reviews are complete.

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Mar 31, 2020
@DHaussermann
Copy link

@jfrerich 1 thing failed during End to End testing.
Autolink is re-writing bot posts. Seems like it's simply a matter of syncing the version bump branch from master so it includes this PR #98
Let me know if you can merge in.

@levb
Copy link
Contributor

levb commented Mar 31, 2020

@DHaussermann since we don't branch for the release - you can just test master perhaps?

I can merge the master changes into this PR, but the release will be cut from master anyway.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @levb 👍

  • Version bump to 1.2 successful
  • Reviewed all Commits since last version bump to ensure all functional changes added to release testing as needed
  • End 2 End testing completed
  • Merge testing of [GH-84] Do not rewrite messages from bots #98 done from Master branch.
    LGTM!

@DHaussermann DHaussermann removed the 3: QA Review Requires review by a QA tester label Mar 31, 2020
@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA labels Mar 31, 2020
@jfrerich jfrerich merged commit 482c9d0 into master Apr 6, 2020
@jfrerich jfrerich deleted the bump-version-v1.1.3 branch April 6, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants