Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin.json #27

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Update plugin.json #27

merged 3 commits into from
Jan 13, 2021

Conversation

justinegeffen
Copy link
Contributor

Updated punctuation for consistency.

@justinegeffen
Update plugin.json
f5c5057 
Updated punctuation for consistency.
@justinegeffen justinegeffen added the 2: Dev Review Requires review by a core committer label Jan 12, 2021
@justinegeffen justinegeffen requested a review from iomodo as a code owner January 12, 2021 20:46
@justinegeffen justinegeffen removed the request for review from crspeller January 12, 2021 20:46
iomodo
iomodo suggested changes Jan 13, 2021
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

plugin.json Outdated Show resolved Hide resolved
larkox
larkox approved these changes Jan 13, 2021
View reviewed changes
Copy link

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of @iomodo 's comment, LGTM.

justinegeffen
justinegeffen commented Jan 13, 2021
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
@justinegeffen justinegeffen requested a review from iomodo January 13, 2021 09:05
iomodo
iomodo suggested changes Jan 13, 2021
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a comma as well. Sorry I missed that :)
"header": "Antivirus plugin for scanning uploaded files to Mattermost, uses ClamAV to scan files. See [documentation here](https://github.com/mattermost/mattermost-plugin-antivirus).",

justinegeffen
justinegeffen commented Jan 13, 2021
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
iomodo
iomodo approved these changes Jan 13, 2021
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @justinegeffen !

@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 13, 2021
@justinegeffen justinegeffen merged commit 8144192 into master Jan 13, 2021
@justinegeffen justinegeffen deleted the justinegeffen-patch-1 branch January 13, 2021 09:51
@hanzei hanzei added this to the v0.2.0 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iomodo iomodo iomodo approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@justinegeffen @larkox @iomodo @hanzei