Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GolangCI-lint #22

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Integrate GolangCI-lint #22

merged 1 commit into from
Jun 15, 2020

Conversation

nathanaelhoun
Copy link
Contributor

Summary

This PR copies most of the golangci-lint configuration from mattermost/mattermost-plugin-starter-template#90 into this repo. This helps with a consistent code style and should improve code quality over time.

Only one change was needed : permission for manifest file. See mattermost/mattermost-plugin-starter-template#95.

Inspired by mattermost-community/mattermost-plugin-autolink#108.

Ticket Link

Closes #21

@nathanaelhoun nathanaelhoun requested a review from iomodo as a code owner June 14, 2020 17:31
@mattermod
Copy link

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@iomodo iomodo added the 2: Dev Review Requires review by a core committer label Jun 15, 2020
@iomodo iomodo requested a review from jfrerich June 15, 2020 06:37
iomodo
iomodo approved these changes Jun 15, 2020
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT @nathanaelhoun ! thanks for the contribution.

nathanaelhoun
nathanaelhoun commented Jun 15, 2020
View reviewed changes
build/custom.mk
@@ -1 +1 @@
# Include custom targets and environment variables here
# Include custome targets and environment variables here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix this typo

hanzei
hanzei approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanzei hanzei removed the request for review from jfrerich June 15, 2020 09:58
@hanzei hanzei added this to the v0.2.0 milestone Jun 15, 2020
@hanzei
Copy link
Contributor

hanzei commented Jun 15, 2020

Skipping QA review as there are no changes to the product.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 15, 2020
@hanzei hanzei merged commit 7f4fc71 into mattermost-community:master Jun 15, 2020
@nathanaelhoun nathanaelhoun deleted the GH-21-add-golangci-lint branch June 15, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@iomodo iomodo iomodo approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Integrate GolangCI-Lint
4 participants
@nathanaelhoun @mattermod @hanzei @iomodo