Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a server connect error more clearly #7

Closed
aaronrothschild opened this issue Jul 30, 2019 · 9 comments · Fixed by #11
Closed

Throw a server connect error more clearly #7

aaronrothschild opened this issue Jul 30, 2019 · 9 comments · Fixed by #11
Assignees
@anidok
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go

Comments

@aaronrothschild
Copy link
Contributor

If MM can't connect to the clamav server, the returned error is not very clear. You'll notice that it's not working because you can't post any attachments at all and the error says "Error while scanning for viruses"

2019-07-26_11-52-33
@hanzei hanzei added the Help Wanted Community help wanted label Aug 2, 2019
@levb levb added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Oct 13, 2019
@Lumexralph
Copy link

@hanzei I would love to help with this

@hanzei
Copy link
Contributor

hanzei commented Oct 20, 2019

Awesome! Thanks for working on this @Lumexralph 👍

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 20, 2019
@Lumexralph
Copy link

@aaronrothschild How can I reproduce the issue locally? Also, what kind of error message do you think or suggest should be displayed?
@hanzei

@hanzei
Copy link
Contributor

hanzei commented Oct 21, 2019

@Lumexralph You can just configure the Host and Port to something invalid in Step 4 of the installation process (https://github.com/mattermost/mattermost-plugin-antivirus#installation)

@Lumexralph
Copy link

@aaronrothschild what kind of error message do you think or suggest should be displayed?

@aaronrothschild
Copy link
Contributor Author

@aaronrothschild what kind of error message do you think or suggest should be displayed?

@Lumexralph Sorry for the missed reply. I'd suggest something like "File Scanning Server unreachable, contact your Mattermost administrator for assistance"

@levb
Copy link
Contributor

levb commented Dec 3, 2019

@Lumexralph Are you interested in finishing this ticket, or should we put it back up for grabs?

@levb levb added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Dec 10, 2019
@anidok
Copy link
Contributor

anidok commented Dec 14, 2019

@levb I would like to take up this one.

anidok added a commit to anidok/mattermost-plugin-antivirus that referenced this issue Dec 15, 2019
@anidok
[mattermost-communityGH-7] Check Ping for ClamAV server
fc78c4f
@anidok anidok mentioned this issue Dec 15, 2019
Merged
@hanzei
Copy link
Contributor

hanzei commented Dec 16, 2019

Thanks @anidok 👍

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Dec 16, 2019
mattermod added a commit to anidok/mattermost-plugin-antivirus that referenced this issue Dec 18, 2019
@mattermod
Merge branch 'master' into mattermost-communityGH-7-throw-proper-serv…
e538c9b 
…er-connect-error
cpoile pushed a commit that referenced this issue Dec 18, 2019
@anidok @cpoile
[GH-7] Throw a server connect error more clearly (#11)
48a48a5 
* Check ping for ClamAV server

* Remove ClamAV server round trip. Throw custom error message in Scantream function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anidok anidok

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-7] Throw a server connect error more clearly anidok/mattermost-plugin-antivirus
5 participants
@aaronrothschild @levb @Lumexralph @hanzei @anidok