Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod tidy #76

Merged
merged 1 commit into from
Mar 23, 2021
Merged

go mod tidy #76

merged 1 commit into from
Mar 23, 2021

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Mar 13, 2021

Summary

Fix CI

Ticket Link

None

@hanzei hanzei requested a review from jfrerich as a code owner March 13, 2021 10:16
@codecov
Copy link

codecov bot commented Mar 13, 2021 •
edited
Loading

Codecov Report

Merging #76 (57b8cd4) into master (f581459) will decrease coverage by 2.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   26.03%   23.80%   -2.23%     
==========================================
  Files           7        7              
  Lines         315      315              
==========================================
- Hits           82       75       -7     
- Misses        216      222       +6     
- Partials       17       18       +1
Impacted Files Coverage Δ
server/utils.go 72.72% <0.00%> (-21.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f581459...57b8cd4. Read the comment docs.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 13, 2021
@hanzei hanzei requested a review from iomodo March 13, 2021 10:19
@jfrerich jfrerich added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Mar 22, 2021
@jfrerich jfrerich requested a review from DHaussermann March 22, 2021 17:45
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 23, 2021
@hanzei hanzei removed the request for review from DHaussermann March 23, 2021 14:40
@hanzei hanzei added this to the v0.3.0 milestone Mar 23, 2021
@hanzei hanzei merged commit cc1317a into master Mar 23, 2021
@hanzei hanzei deleted the go-mod-tidy branch March 23, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrerich jfrerich jfrerich approved these changes

@iomodo iomodo iomodo approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @iomodo @jfrerich