feat(snapshot creator): Make snapshot creator fault-tolerant #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
force-pushed
the
aov-pla-696-snapshot-generation-fault-tolerance
branch
from
32da308 to
598de62
Compare
tomg10
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Looks correct and should not have any corner cases, it may only get stuck (for instance I've seen postgres queries get stuck on very large queries in the pas), but It's not very probable and there would be an alert for that.
I also suggested we make resilience completely transparent on the RPC API level and suggested a few changes regarding snapshots db schema.
tomg10
previously approved these changes
Dec 21, 2023
RomanBrodetski
previously approved these changes
Jan 3, 2024
RomanBrodetski
approved these changes
Jan 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
🤖 I have created a release *beep* *boop* --- ## [19.0.0](core-v18.13.0...core-v19.0.0) (2024-01-05) ### ⚠ BREAKING CHANGES * **vm:** Release v19 - remove allowlist ([#747](#747)) ### Features * **en:** Make consistency checker work with pruned data ([#742](#742)) ([ae6e18e](ae6e18e)) * **eth_sender:** Remove generic bounds on L1TxParamsProvider in EthSender ([#799](#799)) ([29a4f52](29a4f52)) * **merkle tree:** Finalize metadata calculator snapshot recovery logic ([#798](#798)) ([c83db35](c83db35)) * **prover:** Remove circuit-synthesizer ([#801](#801)) ([1426b1b](1426b1b)) * **prover:** Remove old prover ([#810](#810)) ([8be1925](8be1925)) * **snapshot creator:** Make snapshot creator fault-tolerant ([#691](#691)) ([286c7d1](286c7d1)) * **vm:** Add boojum integration folder ([#805](#805)) ([4071e90](4071e90)) * **vm:** Make utils version-dependent ([#809](#809)) ([e5fbcb5](e5fbcb5)) * **vm:** Release v19 - remove allowlist ([#747](#747)) ([0e2bc56](0e2bc56)) * **vm:** Separate boojum integration vm ([#806](#806)) ([61712a6](61712a6)) ### Bug Fixes * **db:** Fix parsing statement timeout from env ([#818](#818)) ([3f663ec](3f663ec)) * **prover:** Remove old prover subsystems tables ([#812](#812)) ([9d0aefc](9d0aefc)) * **prover:** Remove prover-utils from core ([#819](#819)) ([2ceb911](2ceb911)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: EmilLuta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Makes the snapshot creator tolerant to failures. The snapshot creator now checks whether there's a partially created snapshot on start. If there is, the creator continues producing this snapshot instead of starting from scratch.
Why ❔
Since the snapshot creator can run for an extended amount of time, not having fault tolerance is unmaintainable in the long run.
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.