Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proof-data-handler): exclude batches without object file in GCS #2980

Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9188f8a
feat(proof-data-handler): exclude batches without object file in GCS
pbeza Sep 27, 2024
851e3ed
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 18, 2024
19401af
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 18, 2024
a559c40
Revert unintended code artifact
pbeza Nov 18, 2024
16a0e55
Remove direct dependency on zksync_basic_types
pbeza Nov 18, 2024
5de035b
Use `break` and `return` consistently
pbeza Nov 18, 2024
6e27751
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 18, 2024
8503149
fixup! Remove direct dependency on zksync_basic_types
pbeza Nov 18, 2024
8826898
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 19, 2024
0dd0121
Make batch_ignored_timeout configurable + refine comments
pbeza Nov 19, 2024
1f70f44
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 19, 2024
8a80b02
fixup! Make batch_ignored_timeout configurable + refine comments
pbeza Nov 19, 2024
fe2534b
fixup! Make batch_ignored_timeout configurable + refine comments
pbeza Nov 19, 2024
7e9f9a8
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 19, 2024
ada62fe
Retry failed batches after 1 minute instead of 10 minutes
pbeza Nov 20, 2024
c61c1fa
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 20, 2024
733c27d
Merge remote-tracking branch 'origin/main' into tee/flag-old-batches-…
pbeza Nov 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert unintended code artifact
pbeza committed Nov 18, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tdmorello Tim Morello
commit a559c401a66b170c4ae2c15e205306a448c28e21
12 changes: 0 additions & 12 deletions core/lib/object_store/src/retries.rs
Original file line number Diff line number Diff line change
@@ -28,18 +28,6 @@ impl Request<'_> {
self,
store: &impl fmt::Debug,
max_retries: u16,
f: F,
) -> Result<T, ObjectStoreError>
where
Fut: Future<Output = Result<T, ObjectStoreError>>,
F: FnMut() -> Fut,
{
self.retry_internal(max_retries, f).await
}

async fn retry_internal<T, Fut, F>(
&self,
max_retries: u16,
mut f: F,
) -> Result<T, ObjectStoreError>
where