fix(vm): Fix used bytecodes divergence #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
force-pushed
the
aov-pla-1023-fix-used-bytecodes-divergence
branch
from
f7cfe5c to
0052728
Compare
Detected VM performance changes
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently. |
|
JFYI, reported changes in the runtime are caused by switching to segmented heap (not directly related to this fix, but it was merged in |
joonazan
approved these changes
Aug 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This was referenced Aug 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [16.5.0](prover-v16.4.0...prover-v16.5.0) (2024-08-28) ### Features * **prover_cli:** Add test for status, l1 and config commands. ([#2263](#2263)) ([6a2e3b0](6a2e3b0)) * **prover_cli:** Stuck status ([#2441](#2441)) ([232a817](232a817)) * **prover:** Add ProverJobMonitor ([#2666](#2666)) ([e22cfb6](e22cfb6)) * **prover:** parallelized memory queues simulation in BWG ([#2652](#2652)) ([b4ffcd2](b4ffcd2)) * Provide easy prover setup ([#2683](#2683)) ([30edda4](30edda4)) ### Bug Fixes * **prover_cli:** Remove congif file check ([#2695](#2695)) ([2f456f0](2f456f0)) * **prover_cli:** Update prover cli README ([#2700](#2700)) ([5a9bbb3](5a9bbb3)) * **prover:** change bucket for RAM permutation witnesses ([#2672](#2672)) ([8b4cbf4](8b4cbf4)) * **prover:** fail when fri prover job is not found ([#2711](#2711)) ([8776875](8776875)) * **prover:** Revert use of spawn_blocking in LWG/NWG ([#2682](#2682)) ([edfcc7d](edfcc7d)) * **prover:** speed up LWG and NWG ([#2661](#2661)) ([6243399](6243399)) * **vm:** Fix used bytecodes divergence ([#2741](#2741)) ([923e33e](923e33e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [24.23.0](core-v24.22.0...core-v24.23.0) (2024-08-28) ### Features * Refactor metrics/make API use binaries ([#2735](#2735)) ([8ed086a](8ed086a)) ### Bug Fixes * **api:** Fix duplicate DB connection acquired in `eth_call` ([#2763](#2763)) ([74b764c](74b764c)) * **vm:** Fix used bytecodes divergence ([#2741](#2741)) ([923e33e](923e33e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [24.23.0](core-v24.22.0...core-v24.23.0) (2024-08-28) ### Features * Refactor metrics/make API use binaries ([#2735](#2735)) ([8ed086a](8ed086a)) ### Bug Fixes * **api:** Fix duplicate DB connection acquired in `eth_call` ([#2763](#2763)) ([74b764c](74b764c)) * **vm:** Fix used bytecodes divergence ([#2741](#2741)) ([923e33e](923e33e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes divergence in used bytecodes info between the old and new VMs.
Why ❔
The new VM behaved differently to the old VM on far call if decommitting the called contract leads to out-of-gas revert. The old VM records the called contract bytecode as decommitted in this case; the new one didn't.
Checklist
zk fmtandzk lint.