feat(node-framework): Add API fee params resource #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Aug 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## What ❔ - adds `ApiL1GasLayer` - moves `GasAdjuster` to resources ## Why ❔ - `GasAdjuster` is logically a resource - Sequencer and API should use different fee params providers. I think it was missed when migrating to the framework ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
perekopskiy
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
🤖 I have created a release *beep* *boop* --- ## [24.16.0](core-v24.15.0...core-v24.16.0) (2024-08-08) ### Features * External prover API ([#2538](#2538)) ([129a181](129a181)) * **node-framework:** Add API fee params resource ([#2621](#2621)) ([aff7b65](aff7b65)) * **vlog:** Expose more resource values via opentelemetry ([#2620](#2620)) ([7ae07e4](7ae07e4)) * **vlog:** Report observability config, flush, and shutdown ([#2622](#2622)) ([e23e661](e23e661)) ### Bug Fixes * Bump prover dependencies & rust toolchain ([#2600](#2600)) ([849c6a5](849c6a5)) * **en:** Initialize SyncState in OutputHandler ([#2618](#2618)) ([f0c8506](f0c8506)) * restrictive genesis parsing ([#2605](#2605)) ([d5f8f38](d5f8f38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
ApiFeeInputResourceGasAdjusterto resourcesWhy ❔
GasAdjusteris logically a resourceChecklist
zk fmtandzk lint.