Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): Fix operator refund divergency #2519

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix(vm): Fix operator refund divergency #2519

merged 3 commits into from
Jul 29, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jul 29, 2024

What ❔

Fixes integer underflow in refund computation in the glue code for the new VM.

Why ❔

Leads to refund divergencies.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review July 29, 2024 09:39
@slowli slowli requested review from joonazan and montekki July 29, 2024 09:39
@joonazan joonazan merged commit 2d03f44 into jms-vm2 Jul 29, 2024
55 of 57 checks passed
@joonazan joonazan deleted the aov-pla-999-fix-operator-refund-divergency branch July 29, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonazan joonazan joonazan approved these changes

@montekki montekki Awaiting requested review from montekki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @joonazan