Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(en): Fetch old l1 batch hashes from L1 – metrics #2131

Merged
merged 3 commits into from
Jun 4, 2024
Merged

refactor(en): Fetch old l1 batch hashes from L1 – metrics #2131

merged 3 commits into from
Jun 4, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jun 3, 2024 •
edited
Loading

What ❔

Adds a couple of metrics / logs for tree data fetcher related to fetching data from L1. Follow-up after #2000.

Why ❔

These metrics / logs would allow to track tree data fetcher health more thoroughly.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@slowli slowli marked this pull request as ready for review June 3, 2024 13:15
@slowli slowli added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit af39ca3 Jun 4, 2024
47 checks passed
@slowli slowli deleted the aov-pla-818-fetch-old-l1-batch-hashes-from-l1-metrics branch June 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @popzxc