Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: made unit tests use separate real dbs #213

Merged
merged 36 commits into from
Oct 26, 2023
Merged

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Oct 12, 2023

What ❔

Made unit tests use separate real dbs created in a temporary postgres container.

Why ❔

It makes the tests more realistic and greatly simplifies the dal crate.

@pompon0 pompon0 requested a review from a team as a code owner October 12, 2023 16:51
@pompon0 pompon0 requested review from slowli and popzxc October 12, 2023 17:05
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB tests look significantly nicer than before 👍

@pompon0 pompon0 requested a review from a team as a code owner October 13, 2023 19:53
@pompon0 pompon0 requested review from yorik, alexandrst88, artmakh, hatemosphere, otani88 and slowli and removed request for yorik October 13, 2023 19:53
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f048485) 35.63% compared to head (fd988a3) 35.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   35.63%   35.88%   +0.25%     
==========================================
  Files         520      517       -3     
  Lines       28350    27627     -723     
==========================================
- Hits        10103     9915     -188     
+ Misses      18247    17712     -535     
Files Coverage Δ
core/lib/dal/src/blocks_dal.rs 79.44% <ø> (+6.67%) ⬆️
core/lib/dal/src/blocks_web3_dal.rs 37.01% <ø> (+0.64%) ⬆️
core/lib/dal/src/connection/holder.rs 0.00% <ø> (ø)
core/lib/dal/src/events_dal.rs 100.00% <ø> (ø)
core/lib/dal/src/events_web3_dal.rs 37.77% <ø> (-2.23%) ⬇️
core/lib/dal/src/instrument.rs 56.06% <ø> (+0.83%) ⬆️
core/lib/dal/src/lib.rs 23.07% <ø> (-4.87%) ⬇️
core/lib/dal/src/storage_dal.rs 78.46% <ø> (-1.23%) ⬇️
core/lib/dal/src/storage_logs_dal.rs 79.75% <ø> (+0.74%) ⬆️
core/lib/dal/src/transactions_web3_dal.rs 57.14% <ø> (ø)
... and 6 more

... and 98 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popzxc popzxc enabled auto-merge October 26, 2023 10:47
@popzxc popzxc added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit c1f2f5e Oct 26, 2023
@popzxc popzxc deleted the gprusak-testdb2 branch October 26, 2023 11:47
jrchatruc pushed a commit that referenced this pull request Apr 18, 2024
* feat(call-opcode): Test CALL to zkEVM contract

* wip(call tests): NOT working test_basic_call_with_create_vectors
jrchatruc pushed a commit that referenced this pull request Apr 29, 2024
* feat(call-opcode): Test CALL to zkEVM contract

* wip(call tests): NOT working test_basic_call_with_create_vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants