-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: made unit tests use separate real dbs #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB tests look significantly nicer than before 👍
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 35.63% 35.88% +0.25%
==========================================
Files 520 517 -3
Lines 28350 27627 -723
==========================================
- Hits 10103 9915 -188
+ Misses 18247 17712 -535
☔ View full report in Codecov by Sentry. |
5f1f9a4
to
633b6f0
Compare
hatemosphere
requested changes
Oct 25, 2023
hatemosphere
approved these changes
Oct 26, 2023
popzxc
approved these changes
Oct 26, 2023
jrchatruc
pushed a commit
that referenced
this pull request
Apr 18, 2024
* feat(call-opcode): Test CALL to zkEVM contract * wip(call tests): NOT working test_basic_call_with_create_vectors
jrchatruc
pushed a commit
that referenced
this pull request
Apr 29, 2024
* feat(call-opcode): Test CALL to zkEVM contract * wip(call tests): NOT working test_basic_call_with_create_vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Made unit tests use separate real dbs created in a temporary postgres container.
Why ❔
It makes the tests more realistic and greatly simplifies the dal crate.