Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zk_toolbox): make ecosystem configuration not found error more clear #2128

Closed
wants to merge 9 commits into from
Closed

fix(zk_toolbox): make ecosystem configuration not found error more clear #2128

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ce8c91
fix(zk_toolbox): make ecosystem configuration not found error more clear
zk-Lumi Jun 3, 2024
6c13f3c
Merge branch 'matter-labs:main' into main
zk-Lumi Jun 3, 2024
518a80b
Merge remote-tracking branch 'upstream/main'
zk-Lumi Jun 5, 2024
6748c6e
Merge branch 'main' of https://github.com/zk-Lumi/zksync-era-toolbox-…
zk-Lumi Jun 5, 2024
6418ed6
Merge branch 'matter-labs:main' into main
zk-Lumi Jun 20, 2024
1cc3daa
fix: update wording for ecosystem path message
zk-Lumi Jun 20, 2024
e6889ae
fix: update path
zk-Lumi Jun 20, 2024
91631c4
Merge branch 'matter-labs:main' into main
zk-Lumi Jun 21, 2024
89cd43a
fix: name of chain
zk-Lumi Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zk_toolbox/crates/config/src/ecosystem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl EcosystemConfig {
/// Result of checking if the ecosystem exists.
#[derive(Error, Debug)]
pub enum EcosystemConfigFromFileError {
#[error("Ecosystem configuration not found")]
#[error("Ecosystem configuration not found (make sure you have created one `zk_inception ecosystem create` + are in the ecosystem folder `cd path/to/ecosystem/name`)")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we could do something:
Could not find 'ZkStack.toml' in <path>, please create ecosystem first zk_inception ecosystem create`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most common I see for this error is when people forget to cd into ecosystem folder after zk_inception ecosystem create. Can you think of alternative wording you would prefer to my wording?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably at the end of the create phase, we could show that you have to cd to the new path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a good idea also but I think most people will overlook that, would be good to have it in the error too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deniallugo updated wording + added message in ecosystem created, mind reviewing?

NotExists,
#[error("Invalid ecosystem configuration")]
InvalidConfig { source: anyhow::Error },
Expand Down
Loading