fix(basic_types): bincode deserialization for L2ChainId
#1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
force-pushed
the
l2chainid_bincode
branch
from
16fb461 to
0561d86
Compare
haraldh
force-pushed
the
l2chainid_bincode
branch
from
0561d86 to
10b4a44
Compare
Deniallugo
previously approved these changes
Apr 30, 2024
Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
l2chainid_bincode
branch
from
10b4a44 to
8ff0cb8
Compare
Deniallugo
approved these changes
Apr 30, 2024
EmilLuta
approved these changes
May 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Deniallugo
pushed a commit
that referenced
this pull request
May 7, 2024
## What ❔ Skip the `serde_json` workarounds, if the serializer is not human readable. ## Why ❔ Deserialization with the `bincode` serializer is broken, because it is assumed to be json. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. Signed-off-by: Harald Hoyer <[email protected]>
RomanBrodetski
pushed a commit
that referenced
this pull request
May 8, 2024
🤖 I have created a release *beep* *boop* --- ## [24.1.0](core-v24.0.0...core-v24.1.0) (2024-05-08) ### Features * add `sendRawTransactionWithDetailedOutput` API ([#1806](#1806)) ([6a30a31](6a30a31)) * add getGasPerPubdataByte endpoint ([#1778](#1778)) ([d62dd08](d62dd08)) * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **db:** Implement weak references to RocksDB ([e0d4daa](e0d4daa)) * **en:** Add pruning health checks and rework pruning config ([#1790](#1790)) ([e0d4daa](e0d4daa)) * Extract proof_data_handler into separate crate ([#1677](#1677)) ([f4facee](f4facee)) * Extract several crates from zksync_core ([#1859](#1859)) ([7dcf796](7dcf796)) * **node:** Extract genesis into separate crate ([#1797](#1797)) ([a8c4599](a8c4599)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * prover components versioning ([#1660](#1660)) ([29a4ffc](29a4ffc)) * Update provers current version ([#1872](#1872)) ([bb5f129](bb5f129)) ### Bug Fixes * **basic_types:** bincode deserialization for `L2ChainId` ([#1835](#1835)) ([fde85f4](fde85f4)) * **contract-verifier:** YUL system-mode verification ([#1863](#1863)) ([5aa7d41](5aa7d41)) * **loadtest:** Do not initiate transactions with 0 amount ([#1847](#1847)) ([1bbe108](1bbe108)) ### Performance Improvements * **db:** Fine-tune state keeper cache performance / RAM usage ([#1804](#1804)) ([82bf40e](82bf40e)) * **state-keeper:** Improve `FilterWrittenSlots` l1 batch seal stage ([#1854](#1854)) ([4cf235f](4cf235f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Skip the
serde_jsonworkarounds, if the serializer is not human readable.Why ❔
Deserialization with the
bincodeserializer is broken, because it is assumed to be json.Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.