Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state-keeper): Remove pre_insert_txs step #1812

Merged
merged 7 commits into from
May 14, 2024

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Apr 26, 2024

What ❔

Removes pre_insert_txs l2 block seal step. Instead insert_txs flag should be passed to mark_txs_as_executed_in_l2_block.

Why ❔

Inserting txs with block data right away is faster then insert + updating block data.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@perekopskiy perekopskiy marked this pull request as ready for review April 29, 2024 13:50
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
@RomanBrodetski
Copy link
Collaborator

@perekopskiy let's go for it! Or is there something that blocks this?

@perekopskiy
Copy link
Contributor Author

@RomanBrodetski I'll have to rebase it against main if we want to merge it sooner than #1801. It requires some effort, let me check, maybe 1801 will be merged really soon

Copy link
Contributor

No performance difference detected (anymore)

@perekopskiy perekopskiy merged commit f1c13dd into parallel-miniblock-seal May 14, 2024
40 of 43 checks passed
@perekopskiy perekopskiy deleted the remove-insert-pre-txs-step branch May 14, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants