-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(state-keeper): Remove pre_insert_txs
step
#1812
Merged
perekopskiy
merged 7 commits into
parallel-miniblock-seal
from
remove-insert-pre-txs-step
May 14, 2024
Merged
feat(state-keeper): Remove pre_insert_txs
step
#1812
perekopskiy
merged 7 commits into
parallel-miniblock-seal
from
remove-insert-pre-txs-step
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBrodetski
approved these changes
Apr 30, 2024
slowli
reviewed
May 2, 2024
@perekopskiy let's go for it! Or is there something that blocks this? |
@RomanBrodetski I'll have to rebase it against |
No performance difference detected (anymore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Removes pre_insert_txs l2 block seal step. Instead
insert_txs
flag should be passed tomark_txs_as_executed_in_l2_block
.Why ❔
Inserting txs with block data right away is faster then insert + updating block data.
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.