fix(api): Fix extra DB connection acquisition during tx submission #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
requested review from
RomanBrodetski,
StanislavBreadless and
perekopskiy
perekopskiy
approved these changes
Apr 25, 2024
slowli
deleted the
aov-pla-900-fix-extra-db-connection-acquisition-during-tx-submission
branch
6 tasks
RomanBrodetski
pushed a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [24.0.0](core-v23.1.0...core-v24.0.0) (2024-04-30) ### ⚠ BREAKING CHANGES * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) * shared bridge ([#298](#298)) ### Features * **api:** Allow granular max response size config ([#1642](#1642)) ([83c4034](83c4034)) * **api:** Improve logging for API server ([#1792](#1792)) ([50fbda5](50fbda5)) * **api:** Track params for RPC methods ([#1673](#1673)) ([1a34c8b](1a34c8b)) * **configs:** move ecosystem contracts to contracts ([#1606](#1606)) ([9d52180](9d52180)) * EcPairing precompile as system contract ([#1761](#1761)) ([3071622](3071622)) * Include create2 factory in genesis ([#1775](#1775)) ([597280b](597280b)) * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) ([6a557f7](6a557f7)) * **prover:** remove redundant config fields ([#1787](#1787)) ([a784ea6](a784ea6)) * shared bridge ([#298](#298)) ([8c3478a](8c3478a)) * **tree:** Improved tree pruning ([#1532](#1532)) ([bcb192c](bcb192c)) * **vm-runner:** implement VM runner storage layer ([#1651](#1651)) ([543f9e9](543f9e9)) * **vm:** Extend bootloader memory in the new version ([#1807](#1807)) ([f461b28](f461b28)) ### Bug Fixes * **api:** Fix extra DB connection acquisition during tx submission ([#1793](#1793)) ([9c6ed83](9c6ed83)) * **en:** correct en config vars ([#1809](#1809)) ([d340fbc](d340fbc)) * **en:** Remove duplicate reorg detector ([#1783](#1783)) ([3417941](3417941)) * **kl-factory:** base token ether tests ([#1746](#1746)) ([6cf14a0](6cf14a0)) * **prover:** Fix panics if prover's config is not ready ([#1822](#1822)) ([21d90d7](21d90d7)) * **snapshots_creator:** Remove snapshots during reverts ([#1757](#1757)) ([8d587fd](8d587fd)) * **types:** Add LegacyMixedCall ([#1773](#1773)) ([2b236fe](2b236fe)) * v23 api typo ([#1821](#1821)) ([a11fa86](a11fa86)) * Weaker assert for protocol version for operations ([#1800](#1800)) ([11898c2](11898c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Currently,
TxSender::submit_tx()on the main node acquires 2 DB connections at the same time: one explicitly, and another in batch fee input provider. This PR eliminates this.Also, propagates errors in batch fee input provider, so that they don't lead to panics.
Why ❔
Holding multiple DB connections at the same time can lead to connection starvation, or at worst case (temporary) deadlocks.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.