feat: Post FOSS Dockerfiles refactoring, take 1 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 31.58% 31.58%
=======================================
Files 478 478
Lines 25463 25463
=======================================
Hits 8043 8043
Misses 17420 17420 ☔ View full report in Codecov by Sentry. |
otani88
previously approved these changes
Oct 6, 2023
perekopskiy
reviewed
Oct 6, 2023
Deniallugo
previously approved these changes
Oct 6, 2023
yorik
reviewed
Oct 6, 2023
perekopskiy
previously approved these changes
Oct 6, 2023
hatemosphere
changed the title
# What ❔ Uses PAT token for release please. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ To allow other workflows to be triggered by tags creation. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
🤖 I have created a release *beep* *boop* --- ## [15.1.1](core-v15.1.0...core-v15.1.1) (2023-10-05) ### Bug Fixes * use gauge instead histogram for replication lag metric ([#159](#159)) ([0d952d4](0d952d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
# What ❔ * TracerExecutionStatus and TracerExecutionStopReason are part of the ExecutionEndTracer trait, but they were not publicly available. ## Why ❔ * This breaks external implementations of the ExecutionEndTracer
hatemosphere
changed the title
Deniallugo
approved these changes
Oct 8, 2023
artmakh
approved these changes
Oct 8, 2023
otani88
approved these changes
Oct 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yorik
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
To make a simple
docker buildcommand work without any additional hacksChecklist
zk fmtandzk lint.