Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): Remove old prover #810

Merged
merged 2 commits into from
Jan 3, 2024
Merged

feat(prover): Remove old prover #810

merged 2 commits into from
Jan 3, 2024

Conversation

EmilLuta
Copy link
Contributor

@EmilLuta EmilLuta commented Jan 3, 2024

This is one of many commits, most notable upcoming:

  • remove database tables via migrations
  • move prover related data from core to prover (I.E. prover_utils)

This comes as part of migration to boojum. Old prover is decomissioned; this PR removes what's left of main components of old prover subsystems. It includes:

  • remove old prover
  • remove old prover protocol version
  • untangle old prover and fri prover common dependencies
  • and many more

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

This is one of many commits, most notable upcoming:
- remove database tables via migrations
- move prover related data from core to prover (I.E. prover_utils)

This comes as part of migration to boojum. Old prover is decomissioned;
this PR removes what's left of main components of old prover subsystems.
It includes:
- remove old prover
- remove old prover protocol version
- untangle old prover and fri prover common dependencies
- and many more
RomanBrodetski
RomanBrodetski previously approved these changes Jan 3, 2024
popzxc
popzxc previously approved these changes Jan 3, 2024
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/lib/types/src/proofs.rs Outdated Show resolved Hide resolved
@EmilLuta EmilLuta dismissed stale reviews from popzxc and RomanBrodetski via aa50693 January 3, 2024 11:19
@EmilLuta EmilLuta marked this pull request as draft January 3, 2024 11:20
@EmilLuta EmilLuta marked this pull request as ready for review January 3, 2024 11:44
@EmilLuta EmilLuta enabled auto-merge January 3, 2024 11:45
@EmilLuta EmilLuta added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 8be1925 Jan 3, 2024
32 checks passed
@EmilLuta EmilLuta deleted the evl-remove-old-prover branch January 3, 2024 12:16
github-merge-queue bot pushed a commit that referenced this pull request Jan 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[10.1.0](prover-v10.0.2...prover-v10.1.0)
(2024-01-05)


### Features

* **prover:** Remove circuit-synthesizer
([#801](#801))
([1426b1b](1426b1b))
* **prover:** Remove old prover
([#810](#810))
([8be1925](8be1925))


### Bug Fixes

* **prover:** increase DB polling interval for witness vector generators
([#697](#697))
([94579cc](94579cc))
* **prover:** Remove prover-utils from core
([#819](#819))
([2ceb911](2ceb911))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Jan 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[19.0.0](core-v18.13.0...core-v19.0.0)
(2024-01-05)


### ⚠ BREAKING CHANGES

* **vm:** Release v19 - remove allowlist
([#747](#747))

### Features

* **en:** Make consistency checker work with pruned data
([#742](#742))
([ae6e18e](ae6e18e))
* **eth_sender:** Remove generic bounds on L1TxParamsProvider in
EthSender ([#799](#799))
([29a4f52](29a4f52))
* **merkle tree:** Finalize metadata calculator snapshot recovery logic
([#798](#798))
([c83db35](c83db35))
* **prover:** Remove circuit-synthesizer
([#801](#801))
([1426b1b](1426b1b))
* **prover:** Remove old prover
([#810](#810))
([8be1925](8be1925))
* **snapshot creator:** Make snapshot creator fault-tolerant
([#691](#691))
([286c7d1](286c7d1))
* **vm:** Add boojum integration folder
([#805](#805))
([4071e90](4071e90))
* **vm:** Make utils version-dependent
([#809](#809))
([e5fbcb5](e5fbcb5))
* **vm:** Release v19 - remove allowlist
([#747](#747))
([0e2bc56](0e2bc56))
* **vm:** Separate boojum integration vm
([#806](#806))
([61712a6](61712a6))


### Bug Fixes

* **db:** Fix parsing statement timeout from env
([#818](#818))
([3f663ec](3f663ec))
* **prover:** Remove old prover subsystems tables
([#812](#812))
([9d0aefc](9d0aefc))
* **prover:** Remove prover-utils from core
([#819](#819))
([2ceb911](2ceb911))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: EmilLuta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants