-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth_maxPriorityFeePerGas not available #13
Comments
@LouisWT zkSync Era does support the EIP-1559 transaction-type format which includes maxPriorityFeePerGas and maxFeePerGas parameters. However, it's important to note that zkSync Era does nothing with these max fee parameters. This means that while the transaction format is supported, the specific parameters related to maximum gas fees do not have any effect within the zkSync Era system. |
…imit fix batch gas limit
Reopening this issue, as it's relevant outside from Era context: SDKs may expect this method to exist. |
## What ❔ Fixes #13 Implements `eth_maxPriorityFeePerGas` method. ## Why ❔ This method is a de-facto standard now, and SDKs (e.g. viem) can use it assuming that it's supported. Even given that we're not really using EIP1559, we should still support it and return 0. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
chore: merge main and conflicts
While zkSync era using EIP1559, eth_maxPriorityFeePerGas isn't implemented.
Although eth_maxPriorityFeePerGas is not a standard rpc method of Ethereum, it is very important in practical use, especially for determining gas fee when sending transactions.
Thanks!
The text was updated successfully, but these errors were encountered: