Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_maxPriorityFeePerGas not available #13

Closed
LouisWT opened this issue Mar 24, 2023 · 2 comments · Fixed by #3135
Closed

eth_maxPriorityFeePerGas not available #13

LouisWT opened this issue Mar 24, 2023 · 2 comments · Fixed by #3135
Assignees

Comments

@LouisWT
Copy link

LouisWT commented Mar 24, 2023

While zkSync era using EIP1559, eth_maxPriorityFeePerGas isn't implemented.

curl --url https://zksync2-mainnet.zksync.io \
-X POST \
-H "Content-Type: application/json" \
-d '{ "id": 1, "jsonrpc": "2.0", "method": "eth_maxPriorityFeePerGas" }'

{"jsonrpc":"2.0","error":{"code":-32601,"message":"Method not found"},"id":1}

Although eth_maxPriorityFeePerGas is not a standard rpc method of Ethereum, it is very important in practical use, especially for determining gas fee when sending transactions.

Thanks!

@hatemosphere
Copy link
Member

@LouisWT zkSync Era does support the EIP-1559 transaction-type format which includes maxPriorityFeePerGas and maxFeePerGas parameters. However, it's important to note that zkSync Era does nothing with these max fee parameters. This means that while the transaction format is supported, the specific parameters related to maximum gas fees do not have any effect within the zkSync Era system.
so "method not found" might look a bit misleading, but correct in general

SuccinctPaul pushed a commit to SuccinctPaul/zksync-era that referenced this issue Apr 19, 2024
@popzxc popzxc reopened this Oct 21, 2024
@popzxc
Copy link
Member

popzxc commented Oct 21, 2024

Reopening this issue, as it's relevant outside from Era context: SDKs may expect this method to exist.
So, it should be implemented, but we should always return 0.

@popzxc popzxc self-assigned this Oct 21, 2024
@popzxc popzxc moved this to In Progress in DevEx squad Oct 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2024
## What ❔

Fixes #13 
Implements `eth_maxPriorityFeePerGas` method.

## Why ❔

This method is a de-facto standard now, and SDKs (e.g. viem) can use it
assuming that it's supported.
Even given that we're not really using EIP1559, we should still support
it and return 0.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
@github-project-automation github-project-automation bot moved this from In Progress to Done in DevEx squad Oct 23, 2024
StanislavBreadless pushed a commit that referenced this issue Dec 19, 2024
chore: merge main and conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants