Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set valid fromBlock filter to check creation tx hash from the logs #971

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kiriyaga-txfusion
Copy link
Contributor

What 💻

  • Set valid fromBlock filter to check creation tx hash from the logs

Why ✋

  • With the new version of zksync-ethers v5, specifying fromBlock as 0 is no longer valid, and filtering doesn't have the desired effect. To address this, we need to set the fromBlock filter to 'earliest' to effectively search for the creation transaction hash.

@kiriyaga-txfusion kiriyaga-txfusion merged commit 0126c3e into ethers-v5 Apr 3, 2024
8 checks passed
@kiriyaga-txfusion kiriyaga-txfusion deleted the kiriyaga-txfusion-filter-topics branch April 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants