Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary devDependencies, remove hardhat-zksync-deploy… #870

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: remove unnecessary devDependencies, remove hardhat-zksync-deploy… #870

merged 1 commit into from
Mar 6, 2024

Conversation

kiriyaga-txfusion
Copy link
Contributor

… import from index.ts

What 💻

  • Remove unnecessary devDependencies, remove hardhat-zksync-deploy import from index.ts

Why ✋

  • We need to remove duplicate dependencies in both 'dependencies' and 'devDependencies'. The import of 'hardhat-zksync-deploy' inside index.ts is unnecessary since 'hardhat-zksync-upgradable' does not override its tasks or environment configurations.

@kiriyaga-txfusion kiriyaga-txfusion requested a review from a team as a code owner March 6, 2024 08:57
@kiriyaga-txfusion kiriyaga-txfusion merged commit 8955d34 into main Mar 6, 2024
18 checks passed
@kiriyaga-txfusion kiriyaga-txfusion deleted the kiriyaga-txfusion-upgradable-dependency-resolve branch March 6, 2024 09:55
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-bozin-txfusion nikola-bozin-txfusion nikola-bozin-txfusion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiriyaga-txfusion @nikola-bozin-txfusion @kiriyaga