-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cache invalidation on zksolc version change #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
reviewed
Jan 27, 2025
elfedy
reviewed
Jan 27, 2025
elfedy
reviewed
Jan 28, 2025
Karrq
reviewed
Jan 29, 2025
elfedy
approved these changes
Jan 29, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
can_use_cached
in zksync, so it accounts for the selected version as welltest_zk_cache_ok
is a very basic test that asserts the cache is working correctly (must have)test_zk_cache_invalid_on_version_changed
to demonstrate that changing the zksolc version now recompiles the project.Why ✋
Evidence 📷
Before this change, we had this situation:
Now, it is recompiling after the change.
Documentation 📚
Please ensure the following before submitting your PR: