Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip zk tests for upstream test job #824

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: skip zk tests for upstream test job #824

merged 2 commits into from
Jan 9, 2025

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Jan 9, 2025 •
edited
Loading

What 💻

  • Skip zk tests when running upstream test job.

Why ✋

  • zk tests are run in a separate job.

Evidence 📷

Tests pass

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@nbaztec nbaztec requested a review from a team as a code owner January 9, 2025 14:02
@nbaztec nbaztec merged commit 74d2079 into main Jan 9, 2025
50 checks passed
@nbaztec nbaztec deleted the nish-disable-zk-tests-upstream-job branch January 9, 2025 15:42
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBerguer MBerguer MBerguer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @MBerguer