refactor: Move custom cheatcode logic into a generic handler #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-move-cheatcodes
branch
3 times, most recently
from
fe02675 to
f973f5b
Compare
popzxc
force-pushed
the
popzxc-move-cheatcodes
branch
from
f973f5b to
b38a46c
Compare
nbaztec
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Creates a generic handler for cheat codes that wraps custom execution logic.
Why ✋
It is more generic than a static set of methods in a trait. Reduces the diff with upstream.
Evidence 📷
Trust me bro.