Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back zkvm solc resolution from settings #548

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

elfedy
Copy link
Contributor

@elfedy elfedy commented Aug 26, 2024

Motivation

foundry-compilers api refactor brought a regression regarding using zkvm solc when a solc requirement is specified as logic was lost in the new way to do compiler resolution.

Solution

Use dedicated method with zk specific solc resolution for determining how to assign ZkSolcCompiler's solc field.

Pending

This regression highlights the need to address the following in future PRs:

  • Have a way to identify if we will use zkvm or vanilla solc through the whole compilation flow (from logging to sending the info in verify and storing it on build_info)
  • Have proper integration test to make sure user settings are honored and the correct compiler is being used to compile.

Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree moving solc_version to compilers in the future

@elfedy elfedy merged commit 7513c1c into main Aug 27, 2024
11 checks passed
@elfedy elfedy deleted the elfedy-use-zkvm-solc branch August 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants