fix: bring back zkvm solc resolution from settings #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
foundry-compilers
api refactor brought a regression regarding using zkvm solc when a solc requirement is specified as logic was lost in the new way to do compiler resolution.Solution
Use dedicated method with zk specific solc resolution for determining how to assign ZkSolcCompiler's
solc
field.Pending
This regression highlights the need to address the following in future PRs:
build_info
)