feat: disable batch factory deps by default #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
reviewed
Jul 15, 2024
| /// We batch factory_deps till this upper limit if there are multiple deps. | ||
| /// These batches are then deployed individually | ||
| pub const MAX_FACTORY_DEPENDENCIES_SIZE_BYTES: usize = 100000; // 100kB | ||
| lazy_static::lazy_static! { |
There was a problem hiding this comment.
I'd use once_cell instead of lazy_static but this works anyways
There was a problem hiding this comment.
It shouldn't matter for this scenario, given that we plan on removing this.
Karrq
approved these changes
Jul 15, 2024
This was referenced Jul 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Obtaining a viable byte size for batching factory deps is currently inconsistent and causes flakiness.
Solution
Until a more future-proof solution is possible, it's best to disable it by default.
To enable it
MAX_FACTORY_DEPENDENCIES_SIZE_BYTESenvironment variable can be set to a desired value.