Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: batch factory deps for broadcastable tx #455

Merged
merged 11 commits into from
Jul 3, 2024
Merged

fix: batch factory deps for broadcastable tx #455

merged 11 commits into from
Jul 3, 2024

Conversation

Karrq
Copy link
Contributor

@Karrq Karrq commented Jul 2, 2024 •
edited
Loading

Motivation

Batching factory deps has been added since #412, but support for broadcastable tx (and create) was never done.
After investigating #450 it became clear that the simulation issue was due to this missing feature.

Solution

  1. Batch factory deps in broadcastable txns, creating new transactions as needed
  2. Add support for persisted_factory_deps for transact, used in simulation

The PR also fixes the following issues discovered:

  1. Nonce returned/set by cheatcodes were the full nonce, instead of only the tx nonce
  2. Static calls converted to zk transactions persisted any state changes, instead of ignoring it entirely

@Karrq Karrq linked an issue Jul 2, 2024 that may be closed by this pull request
Code hash not known error when trying to deploy factory contract #450
Closed
2 tasks
@Karrq Karrq requested a review from nbaztec July 2, 2024 20:34
@Karrq Karrq requested a review from Jrigada July 3, 2024 14:37
@Karrq
fix(zk): ignore storage changes in static calls
d0c4c65 
tests(zk): check static-call in broadcast
@Karrq Karrq merged commit ab00f2e into dev Jul 3, 2024
11 checks passed
@Karrq Karrq deleted the fix/broadcast-batched-fdeps branch July 3, 2024 20:18
@Karrq Karrq mentioned this pull request Jul 4, 2024
Merged
@Karrq Karrq mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

@Jrigada Jrigada Awaiting requested review from Jrigada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code hash not known error when trying to deploy factory contract
2 participants
@Karrq @nbaztec