fix: Propagate block environment to zkVM #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(zk): hook system context block number and timestamp to environment
nbaztec
approved these changes
Apr 19, 2024
nbaztec
reviewed
Apr 19, 2024
|
Can you please also add a test case for this |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CrossChainReceiverTest currently has 4 failing tests.
Solution
The assertions that are failing are all related to
block.timestampbeing different than expected, this is because each zk call happens in a new transaction in a new batch, and all batches need to have increasing numbers and timestamps.We override what the VM returns for
block.timestampandblock.numberso we can provide the expected test environment.Notes
Depends on Moonsong-Labs/aave-delivery-infrastructure#3