This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Simulate memory queues in parallel for BWG #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
changed the title
Simulate queues in parallel for witgen
Simulate memory queues in parallel for BWG
Aug 14, 2024
4 tasks
Should be used together with matter-labs/zksync-era#2652 |
EmilLuta
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
The greatest amount of time during BWG is spent simulating queues. At the moment, the queue simulation is single-threaded process. But different queues can be simulated in parallel, since they do not depend on each other.
This pull request does the following:
As a result, a decrease in the time on the BWG by ~40% is observed locally.
Peak RAM decreased by ~30%
Checklist
zk fmt
andzk lint
.