feat: Validate genesis block in executor config #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Nov 23, 2023
| anyhow::ensure!( | ||
| node_config.gossip.key == node_key.public(), | ||
| "config.gossip.key = {:?} doesn't match the secret key {:?}", | ||
| node_config.gossip.key, | ||
| node_key | ||
| ); | ||
|
|
||
| // While justifications may differ among nodes for an arbitrary block, we assume that | ||
| // the genesis block has a hardcoded justification. | ||
| let first_block = storage.first_block(ctx).await.context("first_block")?; |
There was a problem hiding this comment.
I'm not entirely sure whether it's valid for a storage to contain blocks before the genesis block. IMO, it makes reasoning about the storage more difficult, so the current check disallows it.
4 tasks
pompon0
approved these changes
Nov 23, 2023
brunoffranca
approved these changes
Nov 23, 2023
brunoffranca
deleted the
aov-bft-380-validate-genesis-block-in-executor-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Validate genesis block self-consistency and correspondence to storage when an
Executoris created.Why ❔
Allows not to accidentally break a node due to misconfiguration.