fix: Use actual replayed tx's gas and pubdata prices to replay tx. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| zksync_utils = { git = "https://github.com/matter-labs/zksync-era.git", rev = "e10bbdd1e863962552f37e768ae6af649353e4ea" } | ||
| zksync_state = { git = "https://github.com/matter-labs/zksync-era.git", rev = "e10bbdd1e863962552f37e768ae6af649353e4ea" } | ||
| zksync_web3_decl = { git = "https://github.com/matter-labs/zksync-era.git", rev = "e10bbdd1e863962552f37e768ae6af649353e4ea", features = [ | ||
| zksync_basic_types = { git = "https://github.com/matter-labs/zksync-era.git", rev = "0d51cd6f3e65eef1bda981fe96f3026d8e12156d" } |
There was a problem hiding this comment.
in this commit there was added fair_pubdata_price value, that is needed for replaying transaction.
more details here:
matter-labs/zksync-era#2244
| "server", | ||
| "client", |
There was a problem hiding this comment.
zksync_web3_decl does not support client feature on this commit
Comment on lines
+268
to
271
| Web3Error::InternalError(_) | Web3Error::MethodNotImplemented => { | ||
| ErrorCode::InternalError | ||
| } | ||
| Web3Error::NoBlock |
There was a problem hiding this comment.
changes are caused by bumping the version of zksync_ dependencies
Comment on lines
+1429
to
+1441
| let hash = match tx_req.get_tx_hash() { | ||
| Ok(result) => result, | ||
| Err(e) => { | ||
| tracing::error!("Transaction request serialization error: {}", e); | ||
| return futures::future::err(into_jsrpc_error(Web3Error::SerializationError(e))) | ||
| .boxed(); | ||
| } | ||
| }; | ||
| let bytes = match tx_req.get_signed_bytes(&PackedEthSignature::from_rsv( | ||
| &H256::default(), | ||
| &H256::default(), | ||
| 27, | ||
| )) { |
There was a problem hiding this comment.
changes are caused by bumping the version of zksync_ dependencies
mm-zk
previously approved these changes
Aug 6, 2024
mm-zk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
zksync eradependencies versionfork.rsto extract l1 batch gas info.create_l1_batch_envto constructBatchFeeInputfrom values taken from l1 batch details, if memory node is running in fork mode.Why ✋
Context: successful txs from fork fails while replaying them with node.
This is caused by wrong gas/fee values stored in
fee_input_providerthat are used to calculate tx cost.