Allow more emojis. Disallow commentating in goodbyes. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdiamond
reviewed
Dec 28, 2016
| @@ -316,6 +316,8 @@ function updatePostFlair(post, response){ | |||
| //awesome workaround from https://mathiasbynens.be/notes/javascript-unicode | |||
| //for getting accurate character count even when handling emojis | |||
| function countSymbols(string) { | |||
| // Do not count emoji variations and modifiers, http://unicode.org/reports/tr51/index.html | |||
| string = string.replace(/[\u{20E0}\u{20E3}\u{FE0E}\u{FE0F}\u{1F3FB}-\u{1F3FF}]/ug,''); | |||
There was a problem hiding this comment.
What exactly would this prevent, and why would we want to prevent it?
There was a problem hiding this comment.
Oh I see, this would potentially allow more emojis from being weeded out. Can you confirm that calling Array.from(string).length on these emoji variations returns > 1?
There was a problem hiding this comment.
-
It restricts the text after "goodbye" to a period. Users occasionally put commentary there, which leads to more goodbye messages and biased/slower resolution.
-
I tested both changes in my browser but I don't have node.js so you might verify them. I checked out ouijabot to debug why "⚡️" wasn't getting accepted and found that (in my browser)
Array.from("⚡️").length > 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.