Skip to content

Commit

Permalink
usb: dwc3: core: Add shutdown callback for dwc3
Browse files Browse the repository at this point in the history
This patch adds a shutdown callback to USB DWC core driver to ensure that
it is properly shutdown in reboot/shutdown path. This is required
where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after
SMMU translation is disabled as part of SMMU shutdown callback in
system reboot or shutdown path, then IOVAs(I/O virtual address)
which it was using will go on the bus as the physical addresses which
might result in unknown crashes (NoC/interconnect errors).

Acked-by: Felipe Balbi <[email protected]>
Signed-off-by: Sandeep Maheswaram <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Sandeep Maheswaram authored and gregkh committed Apr 14, 2021
1 parent e66bbfb commit 568262b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/usb/dwc3/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1658,6 +1658,11 @@ static int dwc3_remove(struct platform_device *pdev)
return 0;
}

static void dwc3_shutdown(struct platform_device *pdev)
{
dwc3_remove(pdev);
}

#ifdef CONFIG_PM
static int dwc3_core_init_for_resume(struct dwc3 *dwc)
{
Expand Down Expand Up @@ -1975,6 +1980,7 @@ MODULE_DEVICE_TABLE(acpi, dwc3_acpi_match);
static struct platform_driver dwc3_driver = {
.probe = dwc3_probe,
.remove = dwc3_remove,
.shutdown = dwc3_shutdown,
.driver = {
.name = "dwc3",
.of_match_table = of_match_ptr(of_dwc3_match),
Expand Down

0 comments on commit 568262b

Please sign in to comment.