Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #524 Support after version 1.25.5 #525

Merged
merged 1 commit into from
Nov 7, 2024
Merged

FIX #524 Support after version 1.25.5 #525

merged 1 commit into from
Nov 7, 2024

Conversation

pyama86
Copy link
Collaborator

@pyama86 pyama86 commented Nov 7, 2024

@matsumotory Please review.

As reported in the issue, I have addressed the changes made to the structure.
It’s a bit tricky to decide whether to handle this differently based on the version. What do you think?

対応はしましたが、バージョンマクロいれます?

Pull-Request Check List

@matsumotory
Copy link
Owner

最新を追いかける運用でこれまできたから、これで良さそうです。ありがとうございます!

@pyama86
Copy link
Collaborator Author

pyama86 commented Nov 7, 2024

leakあるっぽいんであとでみます。

@pyama86
Copy link
Collaborator Author

pyama86 commented Nov 7, 2024

直しました。コードから読み解くにこれまでは、設定ファイルのオブジェクトにlistenの設定追加して、後続の処理でlistener追加してたと思うのですが、その実装はできなくなってそうなので、ngx_stream_core_listen 相当の処理を実装する必要がありそうなので、その方向に倒しました。

@matsumotory
Copy link
Owner

Very great!

@matsumotory matsumotory merged commit 84d2f05 into master Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants