Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX some memory errors by valgrind #516

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

pyama86
Copy link
Collaborator

@pyama86 pyama86 commented Nov 7, 2023

@matsumotory Please review.
refs: #515

valgrindで検定されているメモリのエラーを修正します。
Nginx.redirectのループについてはコンフィグエラーなので、finalizeでケアしなくてもいいかなと思いました。

Pull-Request Check List

@pyama86 pyama86 force-pushed the fix-valgrind-error branch from 7a35940 to 5954bcd Compare November 7, 2023 14:25
@pyama86 pyama86 marked this pull request as ready for review November 7, 2023 14:26
@pyama86 pyama86 force-pushed the fix-valgrind-error branch from 5954bcd to 09aabb2 Compare November 7, 2023 14:30
@pyama86 pyama86 marked this pull request as draft November 7, 2023 14:31
@pyama86 pyama86 force-pushed the fix-valgrind-error branch 2 times, most recently from 6c6c8e5 to 5bed33e Compare November 7, 2023 14:39
@pyama86 pyama86 marked this pull request as ready for review November 7, 2023 14:42
@pyama86 pyama86 force-pushed the fix-valgrind-error branch from 1be71a9 to 5bed33e Compare November 7, 2023 14:59
@pyama86 pyama86 force-pushed the fix-valgrind-error branch from 5bed33e to 7dc6536 Compare November 7, 2023 15:00
@pyama86 pyama86 force-pushed the fix-valgrind-error branch from d36b4ee to a8c0687 Compare November 7, 2023 15:40
@pyama86
Copy link
Collaborator Author

pyama86 commented Nov 7, 2023

原因はよくわからないけど、opensslのbuildがうまくいかなくなってるので、明日また見ます。

@pyama86 pyama86 force-pushed the fix-valgrind-error branch from 42afab2 to d63d7fa Compare November 7, 2023 16:29
@pyama86 pyama86 force-pushed the fix-valgrind-error branch from d63d7fa to 5ffc104 Compare November 7, 2023 16:36
@pyama86
Copy link
Collaborator Author

pyama86 commented Nov 7, 2023

Actionsのインスタンスが大きくなったっぽくて、いままで1スレッドで動いてたmakeが2で動くようになって、ビルドが正常に終了しなくなっていたので、1に固定した。

@matsumotory matsumotory merged commit ede786f into master Nov 7, 2023
8 checks passed
@matsumotory
Copy link
Owner

Thanks!
finalizeは他のredirectモジュールが複数実行されたときの兼ね合いでやった気がするけど、今あるテストで問題でてないなら大丈夫そう。

@pyama86 pyama86 deleted the fix-valgrind-error branch November 8, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants