Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When subrequest is used, set value is not used. #506

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

pyama86
Copy link
Collaborator

@pyama86 pyama86 commented Mar 2, 2023

Pull-Request Check List

サブリクエストの実行時にも mruby_set_code で値を埋め込もうとしてしまっており、ファイバーの実行結果という意図しない値が設定されてしまう不具合があったので修正しました。1コミットめでテストが落ちて、2コミットめで通るようになってます。

@pyama86 pyama86 merged commit 11956b6 into master Mar 2, 2023
@matsumotory
Copy link
Owner

Thanks!

@pyama86 pyama86 deleted the sub-filter-set-code branch October 12, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants