New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor log(errlogger) methods in ngx_mruby #251

Merged

matsumotory merged 1 commit into matsumotory:master from hfm:refactor-log

Dec 30, 2016

Collaborator

hfm commented Dec 29, 2016

Use MRB_ARGS_REQ(2) instead of MRB_ARGS_ANY() because log methods require only a loglevel and a message.
Use mrb_obj_as_string function to convert an object to Ruby string.


          Refactor log(errlogger) methods in ngx_mruby

ee2df72

* Use MRB_ARGS_REQ(2) instead of MRB_ARGS_ANY() because log methods require only a loglevel and a message.
* Use mrb_obj_as_string (https://github.com/mruby/mruby/blob/1.2.0/src/string.c#L1668-L1680) function to convert an object to Ruby string.

hfm requested a review from matsumotory

December 29, 2016 19:06

matsumotory merged commit 3b15860 into matsumotory:master

Owner

matsumotory commented Dec 30, 2016

Thanks!

hfm deleted the refactor-log branch

December 30, 2016 04:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet