Implement Nginx::SSL.errlogger (and Nginx::SSL.log) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfm
changed the title
matsumotory
reviewed
Sep 26, 2016
| mrb_define_const(mrb, class_ssl, "LOG_WARN", mrb_fixnum_value(NGX_LOG_WARN)); | ||
| mrb_define_const(mrb, class_ssl, "LOG_NOTICE", mrb_fixnum_value(NGX_LOG_NOTICE)); | ||
| mrb_define_const(mrb, class_ssl, "LOG_INFO", mrb_fixnum_value(NGX_LOG_INFO)); | ||
| mrb_define_const(mrb, class_ssl, "LOG_DEBUG", mrb_fixnum_value(NGX_LOG_DEBUG)); |
There was a problem hiding this comment.
Why did you re-implement error log constants for Nginx::SSL class instead of Nginx core class constants like Nginx::LOG_NOTICE?
There was a problem hiding this comment.
I thought it better to re-implement them because Nginx::Stream class has LOG constants. But, come to think of it, I need not have re-implemented them.
I'll remove them.
There was a problem hiding this comment.
Nginx::Stream doesn't have the core class. So, it need to re-implement the constants. While Nginx::SSL have the core class.
There was a problem hiding this comment.
Thanks, I understood it.
|
Thank you for your PR. Your code looks good to me. I commented only one question. Please check it. |
|
Thank you for the change. I'll merge after CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.