Don't assume car network mode as default #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-default-network-mode
Closed
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
VehicleTypedatatype class, the default networkMode used to be set to "car". This default value is not documented in the XML schema. The schema just says the networkMode is optional. This behavior can lead to unexpected results if users forget to set the network mode of a vehicle type. E.g. everything like counts, noise, volumes will be incorrectly calculated.In this PR the default value is removed and an exception thrown if the network mode is accessed without being explicitly defined.
This will break existing scenarios which relied on the previous behavior that every vehicle is a "car" by default. Defining the network mode in the vehicles XML will be mandatory.