make emissions analysis classes public #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this should be fine. |
There was a problem hiding this comment.
With the classes being public it is possible to import them into other packages. It is not possible to do anything with them, because all the methods are package private as well. At least the getters in both classes need to be public, so that it is possible to access the data those classes have collected during event handling.
The EmissionsOnLinkHandler would need a public constructor as well if it is supposed to be used like the equasim project does
|
Oh right, I didn't check that... I'll update my PR and properly check if I can use what I need. Cheers |
|
All right it works fine now. Thanks for the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the https://github.com/eqasim-org/eqasim-java project need to manually copy classes from the emissions.analyse namespace because they were not made public.
I'm using only the 2 classes modified here but there might be other classes that would benefit from being public.