Fix the zeroization test #194
Open
+39
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test used some internal API to test if our zeroization works. We have now switched to the publicly available Ed25519 secret key type. Some additional changes were needed to adjust for the different sizes of the secret key material.
|
The test fails, but CI did not notice this because the make file eats the error code. Not sure why the test fails since it works locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test used some internal API to test if our zeroization works. We have now switched to the publicly available Ed25519 secret key type.
Some additional changes were needed to adjust for the different sizes of the secret key material.