Add test for /admin/whois #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requires => [ $main::API_CLIENTS[0] ], | ||
|
|
||
| do => sub { | ||
| my ( $http ) = @_; |
There was a problem hiding this comment.
Any reason this isn't
requires => [ local_user_fixture() ],
do => sub {
my ( $user ) = @_;
?
|
OK, that comment makes sense. Code LGTM aside from jenkins failure, which I presume is from branch mismatch. |
illicitonion
force-pushed
the
daniel/whois
branch
from
95d041c to
ed3a870
Compare
I accidentally pushed this to develop and reverted it. Spec: matrix-org/matrix-spec-proposals#198 Synapse: matrix-org/synapse#418
illicitonion
force-pushed
the
daniel/whois
branch
from
ed3a870 to
3d6037b
Compare
illicitonion
added a commit
that referenced
this pull request
Dec 3, 2015
Add test for /admin/whois I accidentally pushed this to develop and reverted it. Spec: matrix-org/matrix-spec-proposals#198 Synapse: matrix-org/synapse#418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally pushed this to develop and reverted it.
Spec: matrix-org/matrix-spec-proposals#198
Synapse: matrix-org/synapse#418