Add tests for setting account data (SYT-30) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| my ( $event ) = @_; | ||
|
|
||
| return unless $event->{type} eq "my.test.type" | ||
| and $event->{content}{cats_or_rats} eq "cats"; |
There was a problem hiding this comment.
This wants a terminating return 1; at the end.
There was a problem hiding this comment.
Or a dropped "unless" :)
There was a problem hiding this comment.
Ahyes, that would be neater
|
LGTM modulo comments |
| ); | ||
|
|
||
| check_one_account_data_event( | ||
| $body->{rooms}[0]->{account_data}, "my.test.type", "rats" |
There was a problem hiding this comment.
This inner arrow isn't required; as per STYLE-GUIDE it should be omitteed.
$body->{rooms}[0]{account_data} ...
leonerd
changed the title
NegativeMjark
force-pushed
the
markjh/client_config
branch
from
ac9a7c3 to
e8d5054
Compare
NegativeMjark
added a commit
that referenced
this pull request
Dec 1, 2015
Add tests for setting account data (SYT-30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the API from matrix-org/matrix-spec-proposals#168