Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the replication torture level adjustable #771

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 12, 2019

No description provided.

@richvdh richvdh requested a review from a team December 12, 2019 17:50
@richvdh
Copy link
Member Author

richvdh commented Dec 12, 2019

https://perldoc.perl.org/Getopt/Long.html#Summary-of-Option-Specifications may be helpful to the reviewer...

@@ -109,7 +109,7 @@ sub get_options

return (
'dendron-binary=s' => \$self->{args}{dendron_binary},
'torture-replication+' => \$self->{args}{torture_replication},
'torture-replication:50' => \$self->{args}{torture_replication},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation you linked to seemed to suggest that the colon should be followed by a type, rather than a value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooooooooooooooooooooooooooooo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's special

@richvdh richvdh requested a review from erikjohnston December 16, 2019 11:20
@richvdh richvdh merged commit c8ec275 into develop Dec 16, 2019
@richvdh richvdh deleted the rav/more_torture branch December 16, 2019 11:29
anoadragon453 added a commit that referenced this pull request Mar 20, 2020
…ase-v1.8.x

* origin/release-v1.8.0: (27 commits)
  Test for outliers whose auth events are in a different room
  Test for receiving events with auth events in the wrong room
  enable frozen dicts in synapse (#778)
  Fix c&p error in #779
  Add support for synapse multi DB setups. (#775)
  Add console feedbak for the TAP output mode (#779)
  workaround for matrix-org/synapse#6536 (#772)
  Test for backfilled events whose prev_events cross room boundaries (#769)
  Add dendrite's logs to buildkite's artifacts (#773)
  Make the replication torture level adjustable (#771)
  Add test for removing redactions from search results (#747)
  Sanity-checking of some params (#765)
  Fix some 'undefined value' warnings (#768)
  Remove redundant fallback in on_request_federation_v1_event (#766)
  Deflake an AS test (#764)
  Add tests for outbound v2 invite API
  Fix diagnostics from logout test (#763)
  Add comment to explain what the v1 outbound test relies on
  Re-fix test names
  Fix test names
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants