Tests for missing prevs in incoming transactions #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to test the things that are fixed in matrix-org/synapse#3968.
erikjohnston
reviewed
Oct 1, 2018
| auth_chain_ids => [ | ||
| # XXX I'm not really sure why we have to return our | ||
| # auth_events here, when they are already in the event | ||
| map { $_->[0] } @{ $missing_event_y->{auth_events} }, |
There was a problem hiding this comment.
This is meant to be the full auth chain, rather than just the auth events of the state events.
There was a problem hiding this comment.
k thanks, will update the comment slightly
erikjohnston
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to test the things that are fixed in matrix-org/synapse#3968.
(The first commit is a bit of a refactor; the second updates a currently-disabled test to do something useful.)