Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant lazy members test #467

Merged
merged 11 commits into from
Jul 26, 2018
Merged

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Jul 19, 2018

Tests matrix-org/synapse#3331

(also includes #445)

@ara4n
Copy link
Member Author

ara4n commented Jul 19, 2018

@matrixbot retest this please

@richvdh richvdh requested a review from a team July 26, 2018 14:30
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible. I'd like to see more validation of the filter params.

# Alice syncs again; she should not see any membership events as
# the redundant ones for Bob and Charlie are removed.

# TODO: speed up time and check that if we wait an hour then the server's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this an implementation issue? servers can keep the cache for as long or as short as they want?

@richvdh
Copy link
Member

richvdh commented Jul 26, 2018

looks plausible. I'd like to see more validation of the filter params.

or rather, I'd like to see synapse doing more validation, and I'd like to see sytest doing more validation of that validation.

but I'm not going to insist on it for now.

@ara4n
Copy link
Member Author

ara4n commented Jul 26, 2018

done

@ara4n ara4n assigned richvdh and unassigned ara4n Jul 26, 2018
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better, modulo duplication?

feel free to merge after fixing

matrix_create_filter( $alice, {
room => {
state => {
lazy_load_members => "true",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the same as line 13?

@richvdh richvdh assigned ara4n and unassigned richvdh Jul 26, 2018
@ara4n ara4n merged commit d787f37 into develop Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants