-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant lazy members test #467
Conversation
@matrixbot retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks plausible. I'd like to see more validation of the filter params.
tests/31sync/15lazy-members.pl
Outdated
# Alice syncs again; she should not see any membership events as | ||
# the redundant ones for Bob and Charlie are removed. | ||
|
||
# TODO: speed up time and check that if we wait an hour then the server's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this an implementation issue? servers can keep the cache for as long or as short as they want?
or rather, I'd like to see synapse doing more validation, and I'd like to see sytest doing more validation of that validation. but I'm not going to insist on it for now. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even better, modulo duplication?
feel free to merge after fixing
tests/31sync/15lazy-members.pl
Outdated
matrix_create_filter( $alice, { | ||
room => { | ||
state => { | ||
lazy_load_members => "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the same as line 13?
Tests matrix-org/synapse#3331
(also includes #445)