Tests for history purge transactional API #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
purge_history now has a transactional API, which we should use and test.
richvdh
force-pushed
the
rav/purge_history_txns
branch
from
3b6543b to
db5c653
Compare
| assert_json_keys( $body, "status" ); | ||
| Future->done( $body->{status} ); | ||
| }) | ||
| }, while => sub { $_[0]->get eq 'active' }); |
There was a problem hiding this comment.
I'd use either repeat_until_true or retry_until_success helper functions, as they have a small backoff
There was a problem hiding this comment.
well, I'm deliberately doing my own repeat so that I can distinguish between failure (request fails) and not ready yet (status == 'active').
I've added a backoff.
There was a problem hiding this comment.
Ah ok, I just assumed one of those could be used. Ah well
erikjohnston
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purge_history now has a transactional API, which we should use and test.
(cf matrix-org/synapse#2962)