Test API for adding and removing tags #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
||
| my ( $user, $room_id ); | ||
|
|
||
| matrix_register_user( $http, undef, with_events => 0 )->then( sub { |
There was a problem hiding this comment.
Why is it important that /events hasn't been called for this test?
There was a problem hiding this comment.
It isn't but I dislike calling /events unless we are going to actually use it.
There was a problem hiding this comment.
Then let's make the default false?
There was a problem hiding this comment.
Yeah that would be nicer from my perspective.
|
LGTM |
NegativeMjark
pushed a commit
that referenced
this pull request
Nov 3, 2015
Test API for adding and removing tags
|
Merged as 4e524a4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test changes made in matrix-org/synapse#335
TODO: